Skip to content

Comments

fix: conversation not saving on link create#1949

Merged
mfts merged 2 commits intomainfrom
fix/qa-on-group
Dec 1, 2025
Merged

fix: conversation not saving on link create#1949
mfts merged 2 commits intomainfrom
fix/qa-on-group

Conversation

@mfts
Copy link
Owner

@mfts mfts commented Dec 1, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Refactor

    • Updated link configuration property names for improved consistency.

  • New Features

    • Added ability to enable or disable conversations on individual links.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
papermark Ready Ready Preview Comment Dec 1, 2025 10:02am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 1, 2025 •
edited
Loading

Walkthrough

The changes modify link configuration by renaming a field in default props and adding a new field propagation to the link creation API. Specifically, enabledQuestion is renamed to enableQuestion in default link properties, and enableConversation is added to the link creation payload.

Changes

Cohort / File(s) Change Summary
Link configuration field updates
components/links/link-sheet/index.tsx		 Renamed enabledQuestion to enableQuestion in DEFAULT_LINK_PROPS return object
Link creation API payload
pages/api/links/index.ts		 Added enableConversation field propagation from linkData, defaulting to false when undefined

Possibly related PRs

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: conversation not saving on link create' directly describes the primary change: adding the enableConversation field propagation to ensure conversation settings are properly saved when creating links.
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5be2fe4 and 3027887.

📒 Files selected for processing (2)
  • components/links/link-sheet/index.tsx (1 hunks)
  • pages/api/links/index.ts (1 hunks)
🔇 Additional comments (2)
pages/api/links/index.ts (1)

209-209: LGTM! Fixes conversation not saving on link create.

The explicit default value ensures enableConversation is always set during link creation, addressing the issue mentioned in the PR title. The fallback to false aligns with the frontend default value.

components/links/link-sheet/index.tsx (1)

76-76: LGTM! Fixes field name inconsistency.

The rename from enabledQuestion to enableQuestion correctly aligns with the TypeScript type definition (line 119) and the API usage in pages/api/links/index.ts (lines 185-195). No remaining references to the old field name exist in the codebase.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mfts mfts merged commit f7853a7 into main Dec 1, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2025
@mfts mfts deleted the fix/qa-on-group branch February 12, 2026 06:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mfts